DerDu/SPHERE-Framework

View on GitHub
Application/Transfer/Untis/Import/Service/Data.php

Summary

Maintainability
D
1 day
Test Coverage

Method updateUntisImportLectureship has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        TblUntisImportLectureship $tblUntisImportLectureship = null,
        TblDivision $tblDivision = null,
        TblTeacher $tblTeacher = null,
        TblSubject $tblSubject = null,
        $SubjectGroup = '',
Severity: Minor
Found in Application/Transfer/Untis/Import/Service/Data.php - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function updateUntisImportLectureship(
            TblUntisImportLectureship $tblUntisImportLectureship = null,
            TblDivision $tblDivision = null,
            TblTeacher $tblTeacher = null,
            TblSubject $tblSubject = null,
    Severity: Major
    Found in Application/Transfer/Untis/Import/Service/Data.php and 1 other location - About 6 hrs to fix
    Application/Transfer/Indiware/Import/Service/Data.php on lines 256..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function destroyUntisImportLectureshipByAccount(TblAccount $tblAccount)
        {
    
            $Manager = $this->getConnection()->getEntityManager();
    
    
    Severity: Major
    Found in Application/Transfer/Untis/Import/Service/Data.php and 3 other locations - About 2 hrs to fix
    Application/Transfer/Indiware/Import/Service/Data.php on lines 566..584
    Application/Transfer/Indiware/Import/Service/Data.php on lines 591..609
    Application/Transfer/Indiware/Import/Service/Data.php on lines 616..634

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        public function updateUntisImportLectureshipIsIgnore(TblUntisImportLectureship $tblUntisImportLectureship, $IsIgnore = true)
        {
    
            $Manager = $this->getConnection()->getEntityManager();
    
    
    Severity: Major
    Found in Application/Transfer/Untis/Import/Service/Data.php and 5 other locations - About 2 hrs to fix
    Application/Billing/Bookkeeping/Invoice/Service/Data.php on lines 494..511
    Application/Education/Certificate/Generate/Service/Data.php on lines 167..187
    Application/People/Relationship/Service/Data.php on lines 216..229
    Application/Transfer/Indiware/Import/Service/Data.php on lines 495..513
    Application/Transfer/Indiware/Import/Service/Data.php on lines 541..559

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function destroyUntisImportLectureship(TblUntisImportLectureship $tblUntisImportLectureship)
        {
    
            $Manager = $this->getConnection()->getEntityManager();
    
    
    Severity: Major
    Found in Application/Transfer/Untis/Import/Service/Data.php and 2 other locations - About 1 hr to fix
    Application/Transfer/Indiware/Import/Service/Data.php on lines 641..656
    Application/Transfer/Indiware/Import/Service/Data.php on lines 663..678

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status