Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Common/Frontend/Form/Repository/AbstractField.php

Summary

Maintainability
F
3 days
Test Coverage

Function isChecked has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function isChecked($RequestKey, $Value)
    {

        if (preg_match('!^(.*?)\[(.*?)\]$!is', $RequestKey, $Match)) {
            if (false === strpos($Match[2], '[')) {
Severity: Minor
Found in Common/Frontend/Form/Repository/AbstractField.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setPostValue has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setPostValue(IBridgeInterface &$Template, $RequestKey, $VariableName)
    {

        if (preg_match('!^(.*?)\[(.*?)\]$!is', $RequestKey, $Match)) {
            if (false === strpos($Match[2], '[')) {
Severity: Minor
Found in Common/Frontend/Form/Repository/AbstractField.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File AbstractField.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Common\Frontend\Form\Repository;

use MOC\V\Component\Template\Component\IBridgeInterface;
use SPHERE\Common\Frontend\Ajax\Pipeline;
Severity: Minor
Found in Common/Frontend/Form/Repository/AbstractField.php - About 2 hrs to fix

    Method isChecked has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function isChecked($RequestKey, $Value)
    {

        if (preg_match('!^(.*?)\[(.*?)\]$!is', $RequestKey, $Match)) {
            if (false === strpos($Match[2], '[')) {
    Severity: Major
    Found in Common/Frontend/Form/Repository/AbstractField.php - About 2 hrs to fix

      AbstractField has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class AbstractField extends Extension implements IFieldInterface
{

    /** @var string $Name */
    protected $Name;
      Severity: Minor
      Found in Common/Frontend/Form/Repository/AbstractField.php - About 2 hrs to fix

        Method setPostValue has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function setPostValue(IBridgeInterface &$Template, $RequestKey, $VariableName)
    {

        if (preg_match('!^(.*?)\[(.*?)\]$!is', $RequestKey, $Match)) {
            if (false === strpos($Match[2], '[')) {
        Severity: Minor
        Found in Common/Frontend/Form/Repository/AbstractField.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in Common/Frontend/Form/Repository/AbstractField.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                        return true;
            Severity: Major
            Found in Common/Frontend/Form/Repository/AbstractField.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return true;
              Severity: Major
              Found in Common/Frontend/Form/Repository/AbstractField.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                            return true;
                Severity: Major
                Found in Common/Frontend/Form/Repository/AbstractField.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return true;
                  Severity: Major
                  Found in Common/Frontend/Form/Repository/AbstractField.php - About 30 mins to fix

                    Function setError has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function setError($Message, IIconInterface $Icon = null)
    {
        if( $this->Template ) {
            $this->setTemplateVariable('ElementGroup', 'has-error has-feedback');
            if (null !== $Icon) {
                    Severity: Minor
                    Found in Common/Frontend/Form/Repository/AbstractField.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function setSuccess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function setSuccess($Message, IIconInterface $Icon = null)
    {

        if( $this->Template ) {
            $this->setTemplateVariable('ElementGroup', 'has-success has-feedback');
                    Severity: Minor
                    Found in Common/Frontend/Form/Repository/AbstractField.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function setError($Message, IIconInterface $Icon = null)
    {
        if( $this->Template ) {
            $this->setTemplateVariable('ElementGroup', 'has-error has-feedback');
            if (null !== $Icon) {
                    Severity: Major
                    Found in Common/Frontend/Form/Repository/AbstractField.php and 1 other location - About 4 hrs to fix
                    Common/Frontend/Form/Repository/AbstractField.php on lines 168..186

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 167.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function setSuccess($Message, IIconInterface $Icon = null)
    {

        if( $this->Template ) {
            $this->setTemplateVariable('ElementGroup', 'has-success has-feedback');
                    Severity: Major
                    Found in Common/Frontend/Form/Repository/AbstractField.php and 1 other location - About 4 hrs to fix
                    Common/Frontend/Form/Repository/AbstractField.php on lines 145..162

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 167.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status