Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Common/Frontend/Form/Structure/Form.php

Summary

Maintainability
D
3 days
Test Coverage

Function setError has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    public function setError($Name, $Message, IIconInterface $Icon = null)
    {

        /** @var FormGroup $GridGroup */
        foreach ((array)$this->GridGroupList as $GridGroup) {
Severity: Minor
Found in Common/Frontend/Form/Structure/Form.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setSuccess has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    public function setSuccess($Name, $Message = '', IIconInterface $Icon = null)
    {

        /** @var FormGroup $GridGroup */
        foreach ((array)$this->GridGroupList as $GridGroup) {
Severity: Minor
Found in Common/Frontend/Form/Structure/Form.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($FormGroup, $FormButtonList = null, $Action = '', $Data = array())
    {

        if (!is_array($FormGroup)) {
            $FormGroup = array($FormGroup);
Severity: Minor
Found in Common/Frontend/Form/Structure/Form.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getHash has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getHash()
    {
        $HashList = array();

        if (empty($this->Hash)) {
Severity: Minor
Found in Common/Frontend/Form/Structure/Form.php - About 1 hr to fix

    Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($FormGroup, $FormButtonList = null, $Action = '', $Data = array())
    {

        if (!is_array($FormGroup)) {
            $FormGroup = array($FormGroup);
    Severity: Minor
    Found in Common/Frontend/Form/Structure/Form.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                              if (is_object($Frontend)) {
                                            $HashList[] = get_class($Frontend);
                                        }
      Severity: Major
      Found in Common/Frontend/Form/Structure/Form.php - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function setError($Name, $Message, IIconInterface $Icon = null)
    {

        /** @var FormGroup $GridGroup */
        foreach ((array)$this->GridGroupList as $GridGroup) {
        Severity: Major
        Found in Common/Frontend/Form/Structure/Form.php and 1 other location - About 2 hrs to fix
        Common/Frontend/Form/Structure/Form.php on lines 131..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function setSuccess($Name, $Message = '', IIconInterface $Icon = null)
    {

        /** @var FormGroup $GridGroup */
        foreach ((array)$this->GridGroupList as $GridGroup) {
        Severity: Major
        Found in Common/Frontend/Form/Structure/Form.php and 1 other location - About 2 hrs to fix
        Common/Frontend/Form/Structure/Form.php on lines 91..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status