DerDu/SPHERE-Framework

View on GitHub
System/Database/Binding/AbstractSetup.php

Summary

Maintainability
A
1 hr
Test Coverage

Function createColumn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    final protected function createColumn(Table $Table, $Name, $Type = self::FIELD_TYPE_STRING, $IsNull = false, $Default = null)
    {

        if (!$this->getConnection()->hasColumn($Table->getName(), $Name)) {
            if( $Default === null ) {
Severity: Minor
Found in System/Database/Binding/AbstractSetup.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createColumn has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    final protected function createColumn(Table $Table, $Name, $Type = self::FIELD_TYPE_STRING, $IsNull = false, $Default = null)
Severity: Minor
Found in System/Database/Binding/AbstractSetup.php - About 35 mins to fix

    Function createServiceKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        final protected function createServiceKey(Table $Table, $ServiceTable)
        {
    
            if( $ServiceTable instanceof AbstractEntity || $ServiceTable instanceof Element ) {
                $Name = $ServiceTable->getEntityShortName();
    Severity: Minor
    Found in System/Database/Binding/AbstractSetup.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status