Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
xplain/app/Row.class.php

Summary

Maintainability
F
1 wk
Test Coverage

Method performExtraAnalysis has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function performExtraAnalysis() {
        // La colonne extra contient des infos multiples alors on utilise un tableau d'information
        // Par contre l'état (danger ou success) reste global à la cellule et est à gérer au cas par cas
        $infos = array();
        // Contient Using temporary; Using filesort
Severity: Major
Found in xplain/app/Row.class.php - About 3 hrs to fix

    Function performExtraAnalysis has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function performExtraAnalysis() {
        // La colonne extra contient des infos multiples alors on utilise un tableau d'information
        // Par contre l'état (danger ou success) reste global à la cellule et est à gérer au cas par cas
        $infos = array();
        // Contient Using temporary; Using filesort
    Severity: Minor
    Found in xplain/app/Row.class.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function performKeyAnalysis has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function performKeyAnalysis() {
        $this->cells['key']->v = str_replace(',', ', ', $this->cells['key']->v);
        $this->cells['possible_keys']->v = str_replace(',', ', ', $this->cells['possible_keys']->v);

        if ($this->cells['key']->v) {
    Severity: Minor
    Found in xplain/app/Row.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method performTypeAnalysis has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function performTypeAnalysis() {
        if (!$this->cells['type']->v) return;
        if ($this->cells['type']->v == 'ALL') {
            $this->cells['type']->setWarning();
        }
    Severity: Minor
    Found in xplain/app/Row.class.php - About 1 hr to fix

      Method performKeyAnalysis has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function performKeyAnalysis() {
        $this->cells['key']->v = str_replace(',', ', ', $this->cells['key']->v);
        $this->cells['possible_keys']->v = str_replace(',', ', ', $this->cells['possible_keys']->v);

        if ($this->cells['key']->v) {
      Severity: Minor
      Found in xplain/app/Row.class.php - About 1 hr to fix

        Function getPrimaryKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getPrimaryKey() {
        if (is_array($this->_keys)) {
            foreach($this->_keys as $key) {
                if ($key->isPrimary()) return $key;
            }
        Severity: Minor
        Found in xplain/app/Row.class.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function performExtraAnalysis() {
        // La colonne extra contient des infos multiples alors on utilise un tableau d'information
        // Par contre l'état (danger ou success) reste global à la cellule et est à gérer au cas par cas
        $infos = array();
        // Contient Using temporary; Using filesort
        Severity: Major
        Found in xplain/app/Row.class.php and 1 other location - About 4 days to fix
        xplain/app/Row.php on lines 92..208

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 790.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function performKeyAnalysis() {
        $this->cells['key']->v = str_replace(',', ', ', $this->cells['key']->v);
        $this->cells['possible_keys']->v = str_replace(',', ', ', $this->cells['possible_keys']->v);

        if ($this->cells['key']->v) {
        Severity: Major
        Found in xplain/app/Row.class.php and 1 other location - About 3 days to fix
        xplain/app/Row.php on lines 215..260

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 576.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function performTypeAnalysis() {
        if (!$this->cells['type']->v) return;
        if ($this->cells['type']->v == 'ALL') {
            $this->cells['type']->setWarning();
        }
        Severity: Major
        Found in xplain/app/Row.class.php and 1 other location - About 1 day to fix
        xplain/app/Row.php on lines 267..303

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 275.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (preg_match('/^.+?\\..+?\\..+$/', $this->cells['ref']->v)) {
            $ref_infos = explode('.', $this->cells['ref']->v);
            $this->cells['ref']->info = "The <code>{$ref_infos[2]}</code> column of table <code>{$ref_infos[1]}</code> is compared to
                                        <code>{$this->cells['key']->v}</code> key of table <code>{$this->cells['table']->v}</code>";
        }
        Severity: Minor
        Found in xplain/app/Row.class.php and 1 other location - About 50 mins to fix
        xplain/app/Row.php on lines 330..334

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function performSelectTypeAnalysis() {
        $infos = array(
            'SIMPLE' => 'Simple SELECT (not using UNION or subqueries)',
            'PRIMARY' => 'Outermost SELECT',
            'UNION' => 'Second or later SELECT statement in a UNION',
        Severity: Minor
        Found in xplain/app/Row.class.php and 1 other location - About 40 mins to fix
        xplain/app/Row.php on lines 70..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status