Sign upLogin

Derek-R-S/Light-Reflective-Mirror

View on GitHub
Star
ServerProject-DONT-IMPORT-INTO-UNITY/LRM/RelayHandler/RelayHandlerRoomMethods.cs

Summary

Maintainability
B
6 hrs
Test Coverage

Method JoinRoom has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private void JoinRoom(int clientId, string serverId, bool canDirectConnect, string localIP)
        {
            LeaveRoom(clientId);

            if (_cachedRooms.ContainsKey(serverId))
Severity: Major
Found in ServerProject-DONT-IMPORT-INTO-UNITY/LRM/RelayHandler/RelayHandlerRoomMethods.cs - About 2 hrs to fix

    Method LeaveRoom has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void LeaveRoom(int clientId, int requiredHostId = -1)
        {
            for (int i = 0; i < rooms.Count; i++)
            {
                // if host left
    Severity: Minor
    Found in ServerProject-DONT-IMPORT-INTO-UNITY/LRM/RelayHandler/RelayHandlerRoomMethods.cs - About 1 hr to fix

      Method CreateRoom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private void CreateRoom(int clientId, int maxPlayers, string serverName, bool isPublic, string serverData, bool useDirectConnect, string hostLocalIP, bool useNatPunch, int port)
        {
            LeaveRoom(clientId);
            Program.instance.NATConnections.TryGetValue(clientId, out IPEndPoint hostIP);
      Severity: Minor
      Found in ServerProject-DONT-IMPORT-INTO-UNITY/LRM/RelayHandler/RelayHandlerRoomMethods.cs - About 1 hr to fix

        Method CreateRoom has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                private void CreateRoom(int clientId, int maxPlayers, string serverName, bool isPublic, string serverData, bool useDirectConnect, string hostLocalIP, bool useNatPunch, int port)
        Severity: Major
        Found in ServerProject-DONT-IMPORT-INTO-UNITY/LRM/RelayHandler/RelayHandlerRoomMethods.cs - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status