DeuxHuitHuit/framework.js

View on GitHub

Showing 25 of 25 total issues

Function gotoPage has 156 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const gotoPage = function (obj, previousPoppedUrl, pageData = {}, changeUrl = true) {
        let nextPage;
        let route = '';

        /**
Severity: Major
Found in src/app-mediator.js - About 6 hrs to fix

    Function browserDetector has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const browserDetector = (function () {
    
            /**
             * Get the user agent
             * @name getUserAgent
    Severity: Major
    Found in src/app-device.js - About 3 hrs to fix

      Function storage has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const storage = function (storage) {
              return {
      
                  /**
                   * Return the value associated with the given key
      Severity: Major
      Found in src/app-storage.js - About 2 hrs to fix

        Function createPageModel has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const createPageModel = function (key, model, override) {
        
                /**
                 * Page Model is a Factory function for page instances.
                 * @name factory
        Severity: Major
        Found in src/app-pages.js - About 2 hrs to fix

          Function factory has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  const factory = function (pageData) {
                      let modelRef;
                      let isInited = false;
                      
                      if (typeof model === 'object') {
          Severity: Major
          Found in src/app-pages.js - About 2 hrs to fix

            File app-pages.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /**
             * Pages are controller that are activated on a url basis.
             *
             * @fileoverview Defines and exports pages
             *
            Severity: Minor
            Found in src/app-pages.js - About 2 hrs to fix

              File app-mediator.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /**
               * Mediator controls the current page and modules
               *
               * @fileoverview Defines the App Mediator
               *
              Severity: Minor
              Found in src/app-mediator.js - About 2 hrs to fix

                Function execute has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    const execute = function (actions, key, data, cb) {
                        let sp = 0;
                        let outerCall = false;
                        const read = function (f) {
                            if (typeof f.read === 'function') {
                Severity: Major
                Found in src/app-actions.js - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      const safeSessionStorage = function () {
                          try {
                              return storage(window.sessionStorage);
                          } catch (e) {
                              App.log({
                  Severity: Major
                  Found in src/app-storage.js and 1 other location - About 2 hrs to fix
                  src/app-storage.js on lines 136..147

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 76.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      const safeLocalStorage = function () {
                          try {
                              return storage(window.localStorage);
                          } catch (e) {
                              App.log({
                  Severity: Major
                  Found in src/app-storage.js and 1 other location - About 2 hrs to fix
                  src/app-storage.js on lines 149..160

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 76.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function loadSuccess has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          const loadSuccess = function (response) {
                  
                              // if a redirection was detected by the browser with the original goto replicate it
                              if (!!response.redirected) {
                                  window.history.replaceState({
                  Severity: Minor
                  Found in src/app-mediator.js - About 2 hrs to fix

                    Function matchRoute has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        const matchRoute = function (route, routes) {
                            let index = -1;
                            const found = function (i) {
                                index = i;
                                return false; // exit every
                    Severity: Minor
                    Found in src/app-pages.js - About 1 hr to fix

                      Function string has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              string: function (testRoute, route, cb) {
                                  let regex;
                                  // be sure to escape uri
                                  route = decodeURIComponent(route);
                                  
                      Severity: Minor
                      Found in src/app-pages.js - About 1 hr to fix

                        Function initApplication has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            const initApplication = function (root) {
                                // assure root node
                                if (!!root && !!document.querySelector(root)) {
                                    ROOT = root;
                                }
                        Severity: Minor
                        Found in src/app.js - About 1 hr to fix

                          Function clear has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                      clear: function (regexp) {
                                          let result = false;
                                          try {
                                              if (!regexp) {
                                                  storage.clear();
                          Severity: Minor
                          Found in src/app-storage.js - About 1 hr to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if (!!changeUrl) {
                                                        window.history.pushState({
                                                            data: {
                                                                mediator: true
                                                            }
                            Severity: Major
                            Found in src/app-mediator.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if (!App.pages.loaded(obj)) {
                                                          // Raise the flag to mark we are in the process
                                                          // of loading a new page
                                                          mediatorIsLoadingPage = true;
                              
                              
                              Severity: Major
                              Found in src/app-mediator.js - About 45 mins to fix

                                Function loaded has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    const loaded = function (v, fx, delay, maxRetriesCount, counter) {
                                Severity: Minor
                                Found in src/app-loaded.js - About 35 mins to fix

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if (!pageModels[keyModel]) {
                                              App.log({fx: 'error', args: 'Model "' + keyModel + '" not found.'});
                                              return false;
                                          }
                                  Severity: Minor
                                  Found in src/app-pages.js and 1 other location - About 35 mins to fix
                                  src/app-pages.js on lines 379..382

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 46.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                                      try {
                                                          storage[key] = !value ? '' : value + '';
                                                          result = true;
                                                      } catch (e) {
                                                          App.log({
                                  Severity: Minor
                                  Found in src/app-storage.js and 2 other locations - About 35 mins to fix
                                  src/app-storage.js on lines 80..90
                                  src/app-storage.js on lines 107..130

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 46.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language