Sign upLogin

DevGroup-ru/yii2-jstree-widget

View on GitHub
Star

Showing 37 of 37 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function init()
    {
        if (true === empty($this->className) || false === is_subclass_of($this->className, ActiveRecord::class)) {
            throw new InvalidConfigException('"className" param must be set and must be child of ActiveRecord');
        }
Severity: Major
Found in src/actions/nestedset/NodeMoveAction.php and 1 other location - About 7 hrs to fix
src/actions/nestedset/FullTreeDataAction.php on lines 37..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 242.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function init()
    {
        if (true === empty($this->className) || false === is_subclass_of($this->className, ActiveRecord::class)) {
            throw new InvalidConfigException('"className" param must be set and must be child of ActiveRecord');
        }
Severity: Major
Found in src/actions/nestedset/FullTreeDataAction.php and 1 other location - About 7 hrs to fix
src/actions/nestedset/NodeMoveAction.php on lines 43..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 242.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File NodeMoveAction.php has 430 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace devgroup\JsTreeWidget\actions\nestedset;

use devgroup\JsTreeWidget\widgets\TreeWidget;
Severity: Minor
Found in src/actions/nestedset/NodeMoveAction.php - About 6 hrs to fix

    Method move has 126 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function move($position = null, $siblings = [], $oldParentId)
    {
        $class = $this->className;
        if (null === $oldParent = $class::findOne($oldParentId)) {
            return ['error' => Yii::t('jstw', "Old parent with id '{id}' not found!", ['id' => $oldParentId])];
    Severity: Major
    Found in src/actions/nestedset/NodeMoveAction.php - About 5 hrs to fix

      Method moveMultiRoot has 112 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function moveMultiRoot($position = null, $siblings = [], $oldParentId)
    {
        $class = $this->className;
        if ((int)$oldParentId == 0) {
            return ['error' => Yii::t('jstw', 'Can not move root node as child!')];
      Severity: Major
      Found in src/actions/nestedset/NodeMoveAction.php - About 4 hrs to fix

        Method reorder has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function reorder($oldPosition = null, $position = null, $siblings = [])
    {
        if (null === $oldPosition || null === $position || true === empty($siblings)) {
            return ['error' => Yii::t('jstw', 'Invalid data provided!')];
        }
        Severity: Major
        Found in src/actions/nestedset/NodeMoveAction.php - About 2 hrs to fix

          Method run has 69 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function run()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;

        /** @var \yii\db\ActiveRecord $class */
          Severity: Major
          Found in src/actions/AdjacencyList/FullTreeDataAction.php - About 2 hrs to fix

            Function move has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function move($position = null, $siblings = [], $oldParentId)
    {
        $class = $this->className;
        if (null === $oldParent = $class::findOne($oldParentId)) {
            return ['error' => Yii::t('jstw', "Old parent with id '{id}' not found!", ['id' => $oldParentId])];
            Severity: Minor
            Found in src/actions/nestedset/NodeMoveAction.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                public function run()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;

        /** @var \yii\db\ActiveRecord $class */
            Severity: Minor
            Found in src/actions/AdjacencyList/FullTreeDataAction.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has 61 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function run()
    {
        if (!is_array($this->treeDataRoute)) {
            throw new InvalidConfigException("Attribute treeDataRoute is required to use TreeWidget.");
        }
            Severity: Major
            Found in src/widgets/TreeWidget.php - About 2 hrs to fix

              Function prepareNestedData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function prepareNestedData($data, $lft = 0, $rgt = null, $root = 0)
    {
        $res = [];
        foreach ($data as $row) {
            $currentRoot = isset($row[$this->rootAttribute]) ? $row[$this->rootAttribute] : 0;
              Severity: Minor
              Found in src/actions/nestedset/FullTreeDataAction.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has 59 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function run()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;

        /** @var \yii\db\ActiveRecord $class */
              Severity: Major
              Found in src/actions/AdjacencyList/PartialTreeDataAction.php - About 2 hrs to fix

                Method prepareNestedData has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function prepareNestedData($data, $lft = 0, $rgt = null, $root = 0)
    {
        $res = [];
        foreach ($data as $row) {
            $currentRoot = isset($row[$this->rootAttribute]) ? $row[$this->rootAttribute] : 0;
                Severity: Major
                Found in src/actions/nestedset/FullTreeDataAction.php - About 2 hrs to fix

                  File TreeWidget.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

namespace devgroup\JsTreeWidget\widgets;

use Yii;
                  Severity: Minor
                  Found in src/widgets/TreeWidget.php - About 2 hrs to fix

                    Method adjacencyJs has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function adjacencyJs()
    {
        $changeParentJs = '';
        if ($this->changeParentAction !== false) {
            $changeParentUrl = is_array($this->changeParentAction) ? Url::to($this->changeParentAction) : $this->changeParentAction;
                    Severity: Major
                    Found in src/widgets/TreeWidget.php - About 2 hrs to fix

                      Method run has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function run()
    {
        $id = 'input_tree__' . $this->getId();
        $this->options['id'] = $id;
                      Severity: Minor
                      Found in src/widgets/TreeInput.php - About 1 hr to fix

                        Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function run()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;

        /** @var \yii\db\ActiveRecord $class */
                        Severity: Minor
                        Found in src/actions/AdjacencyList/PartialTreeDataAction.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function contextMenuOptions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function contextMenuOptions($functionName)
    {
        $items = [];
        $conditionItems = "";
        foreach ($this->contextMenuItems as $index => $item) {
                        Severity: Minor
                        Found in src/widgets/TreeWidget.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method contextMenuOptions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function contextMenuOptions($functionName)
    {
        $items = [];
        $conditionItems = "";
        foreach ($this->contextMenuItems as $index => $item) {
                        Severity: Minor
                        Found in src/widgets/TreeWidget.php - About 1 hr to fix

                          Method nestedSetJs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function nestedSetJs()
    {
        $js = "";
        if (false !== $this->reorderAction || false !== $this->changeParentAction) {
            $action = $this->reorderAction ?: $this->changeParentAction;
                          Severity: Minor
                          Found in src/widgets/TreeWidget.php - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language