Sign upLogin

DeveloperCAP/MLCAT

View on GitHub
Star

Showing 109 of 109 total issues

Function generate_kmeans_clustering has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def generate_kmeans_clustering(mbox_filename, output_filename, author_uid_filename, json_filename, top_n = None):
Severity: Minor
Found in lib/input/mbox/keyword_clustering.py - About 35 mins to fix

    Function generate_wh_table_authors has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def generate_wh_table_authors(nodelist_filename, edgelist_filename, output_filename, ignore_lat=False, time_limit=None):
    Severity: Minor
    Found in lib/analysis/author/wh_table.py - About 35 mins to fix

      Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def get(json_filename, output_filename, active_score, passive_score, write_to_file=True):
      Severity: Minor
      Found in lib/analysis/author/ranking.py - About 35 mins to fix

        Function add_to_multigraph has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def add_to_multigraph(graph_obj, discussion_graph, json_data, nbunch, label_prefix=''):
        Severity: Minor
        Found in lib/analysis/author/graph/interaction.py - About 35 mins to fix

          Function author_interaction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def author_interaction(clean_data, graph_nodes, graph_edges, pajek_file, ignore_lat=True):
          Severity: Minor
          Found in lib/analysis/author/graph/generate.py - About 35 mins to fix

            Function write_uid_map has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def write_uid_map(self,from_index=1, to_index=last_uid_read, uid_map_filename="thread_uid_map.json"):
        """
    
        To ensure that references are correctly recorded in the JSON file such that there are no references to mails that
        do not exist and to ease the processing of headers, a map with the string in the Message-Id field of the header to
            Severity: Minor
            Found in lib/input/check_headers.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                with open(nodelist_filename, 'w') as node_file:
        for node_str in nodes:
            node_file.write(node_str + "\n")
            Severity: Minor
            Found in lib/analysis/thread/graph/edge_list.py and 1 other location - About 30 mins to fix
            lib/analysis/thread/graph/edge_list.py on lines 33..35

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                with open(nodelist_filename, 'w') as node_file:
        for node_str in nodes:
            node_file.write(node_str + "\n")
            Severity: Minor
            Found in lib/analysis/thread/graph/edge_list.py and 1 other location - About 30 mins to fix
            lib/analysis/thread/graph/edge_list.py on lines 70..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function get_uid_map has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def get_uid_map(input_file='clean_data.json',output_file="author_uid_map.json"):
    """
    This function is used to generate and write to a JSON file the mapping of authors to a unique integer identifier.
    Authors are identified through a regular expression search for their email addresses. The integer identifiers
    generated are used in other modules like the generation and statistical analysis of hyperedges.
            Severity: Minor
            Found in lib/util/author.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language