Sign upLogin

DevelopingCoder/cs61a_hintr

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method aggregate_changes has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def aggregate_changes
    changes = {}
    confirmed_additions = params[:confirmed_additions]
    additions = []
    if confirmed_additions
Severity: Minor
Found in app/controllers/application_controller.rb - About 1 hr to fix

    Method sort_messages has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sort_messages(sort_type, messages, is_hint)
    message_upvotes = {}
    message_downvotes = {}
    messages.each do |message|
        upvotes = 0
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 hr to fix

      Method sort_messages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def sort_messages(sort_type, messages, is_hint)
    message_upvotes = {}
    message_downvotes = {}
    messages.each do |message|
        upvotes = 0
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The use of eval is a serious security risk.
      Open

                  edits += [eval(edit)]
      Severity: Minor
      Found in app/controllers/application_controller.rb by rubocop

      This cop checks for the use of Kernel#eval and Binding#eval.

      Example:

      # bad

eval(something)
binding.eval(something)

      The use of eval is a serious security risk.
      Open

                  deletions += [eval(deletion)]
      Severity: Minor
      Found in app/controllers/application_controller.rb by rubocop

      This cop checks for the use of Kernel#eval and Binding#eval.

      Example:

      # bad

eval(something)
binding.eval(something)

      The use of eval is a serious security risk.
      Open

              changes += [eval(change)]
      Severity: Minor
      Found in app/controllers/application_controller.rb by rubocop

      This cop checks for the use of Kernel#eval and Binding#eval.

      Example:

      # bad

eval(something)
binding.eval(something)

      The use of eval is a serious security risk.
      Open

                  additions += [eval(addition)]
      Severity: Minor
      Found in app/controllers/application_controller.rb by rubocop

      This cop checks for the use of Kernel#eval and Binding#eval.

      Example:

      # bad

eval(something)
binding.eval(something)

      There are no issues that match your filters.

      Category
      Status