Sign upLogin

DevelopingCoder/cs61a_hintr

View on GitHub
Star
features/support/seed_helper.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method diff_db has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def diff_db(qset_json)
        diffs = []
        qset_json.each do |qset_name, question_json|
            question_set = QuestionSet.find_by_name(qset_name)
            if not question_set
Severity: Minor
Found in features/support/seed_helper.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for diff_db is too high. [9/6]
Open

    def diff_db(qset_json)
        diffs = []
        qset_json.each do |qset_name, question_json|
            question_set = QuestionSet.find_by_name(qset_name)
            if not question_set
Severity: Minor
Found in features/support/seed_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [32/30]
Open

    def diff_db(qset_json)
        diffs = []
        qset_json.each do |qset_name, question_json|
            question_set = QuestionSet.find_by_name(qset_name)
            if not question_set
Severity: Minor
Found in features/support/seed_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method diff_db has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def diff_db(qset_json)
        diffs = []
        qset_json.each do |qset_name, question_json|
            question_set = QuestionSet.find_by_name(qset_name)
            if not question_set
Severity: Minor
Found in features/support/seed_helper.rb - About 1 hr to fix

    Method seed_db has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def seed_db(qset_json)
    # seed db with qsets in json, expect it to be in same format as question.json
    # also assumes an empty database except for tags (doesn't check for new questions, qsets, or was)
    # so all tags in the seed json should be within tag1-tag10
    qset_json.each do |qset_name, question_json|
    Severity: Minor
    Found in features/support/seed_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status