Sign upLogin

Dhii/callback-abstract

View on GitHub
Star

Showing 49 of 50 total issues

Avoid using short method names like ValidateParamsCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = array(), $context = null);
Severity: Minor
Found in src/ValidateParamsCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like NormalizeMethodCallableCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = array(), $context = null);
Severity: Minor
Found in src/NormalizeMethodCallableCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like InvokeCallbackCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = array(), $context = null);
Severity: Minor
Found in src/InvokeCallbackCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like InvokeCallableCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = array(), $context = null);
Severity: Minor
Found in src/InvokeCallableCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method _invokeCallable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _invokeCallable($callable, $args)
    {
        if (!is_callable($callable)) {
            throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
        }
Severity: Minor
Found in src/InvokeCallableCapableTrait.php - About 1 hr to fix

    Function _invokeCallable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _invokeCallable($callable, $args)
    {
        if (!is_callable($callable)) {
            throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
        }
    Severity: Minor
    Found in src/InvokeCallableCapableTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _createValidationFailedException has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $message = null,
        $code = null,
        RootException $previous = null,
        ValidatorInterface $validator = null,
        $subject = null,
    Severity: Minor
    Found in src/ValidateParamsCapableTrait.php - About 45 mins to fix

      Function _normalizeCallable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _normalizeCallable($callable)
    {
        // Closure remains as such
        if ($callable instanceof Closure) {
            return $callable;
      Severity: Minor
      Found in src/NormalizeCallableCapableTrait.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _normalizeMethodCallable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _normalizeMethodCallable($callable)
    {
        if (is_object($callable) && is_callable($callable)) {
            return array($callable, '__invoke');
        }
      Severity: Minor
      Found in src/NormalizeMethodCallableCapableTrait.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method _invokeCallable uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                return call_user_func_array($callable, $args);
            }
      Severity: Minor
      Found in src/InvokeCallableCapableTrait.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method _invokeCallable uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $target = is_object($callable[0])
                        ? $callable[0]
                        : null;
                }
      Severity: Minor
      Found in src/InvokeCallableCapableTrait.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method _setArgs is not named in camelCase.
      Open

          protected function _setArgs($args)
    {
        $args = $this->_normalizeIterable($args);

        $this->args = $args;
      Severity: Minor
      Found in src/ArgsAwareTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _normalizeIterable is not named in camelCase.
      Open

          abstract protected function _normalizeIterable($iterable);
      Severity: Minor
      Found in src/ArgsAwareTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _createReflectionFunction is not named in camelCase.
      Open

          abstract protected function _createReflectionFunction($functionName);
      Severity: Minor
      Found in src/CreateReflectionForCallableCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _normalizeIterable is not named in camelCase.
      Open

          abstract protected function _normalizeIterable($iterable);
      Severity: Minor
      Found in src/InvokeCallbackCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _createOutOfRangeException is not named in camelCase.
      Open

          abstract protected function _createOutOfRangeException(
        $message = null,
        $code = null,
        RootException $previous = null,
        $argument = null
      Severity: Minor
      Found in src/InvokeCallbackCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _normalizeArray is not named in camelCase.
      Open

          abstract protected function _normalizeArray($value);
      Severity: Minor
      Found in src/InvokeCallableCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _normalizeString is not named in camelCase.
      Open

          abstract protected function _normalizeString($subject);
      Severity: Minor
      Found in src/NormalizeMethodCallableCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method _invokeCallable is not named in camelCase.
      Open

          protected function _invokeCallable($callable, $args)
    {
        if (!is_callable($callable)) {
            throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
        }
      Severity: Minor
      Found in src/InvokeCallableCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = array(), $context = null);
      Severity: Minor
      Found in src/InvokeCallableCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      Severity
      Category
      Status
      Source
      Language