Function _containerGet
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
protected function _containerGet($container, $key)
{
$origKey = $key;
$key = $this->_normalizeKey($key);
// NotFoundExceptionInterface#getDataKey() returns `string` or `Stringable`,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _containerGet
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _containerGet($container, $key)
{
$origKey = $key;
$key = $this->_normalizeKey($key);
// NotFoundExceptionInterface#getDataKey() returns `string` or `Stringable`,
Method _createNotFoundException
has 5 arguments (exceeds 4 allowed). Consider refactoring. Invalid
$message = null,
$code = null,
RootException $previous = null,
BaseContainerInterface $container = null,
$dataKey = null
The method _containerGet() has an NPath complexity of 486. The configured NPath complexity threshold is 200. Open
protected function _containerGet($container, $key)
{
$origKey = $key;
$key = $this->_normalizeKey($key);
// NotFoundExceptionInterface#getDataKey() returns `string` or `Stringable`,
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method _containerGet() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
protected function _containerGet($container, $key)
{
$origKey = $key;
$key = $this->_normalizeKey($key);
// NotFoundExceptionInterface#getDataKey() returns `string` or `Stringable`,
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using short method names like ContainerGetCapableTrait::__(). The configured minimum method name length is 3. Invalid
abstract protected function __($string, $args = [], $context = null);
- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}
Source https://phpmd.org/rules/naming.html#shortmethodname
The method __ is not named in camelCase. Invalid
abstract protected function __($string, $args = [], $context = null);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}