src/ContainerHasCapableTrait.php
Function _containerHas has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function _containerHas($container, $key)
{
$key = $this->_normalizeKey($key);
if ($container instanceof BaseContainerInterface) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using short method names like ContainerHasCapableTrait::__(). The configured minimum method name length is 3. Invalid
Invalid
abstract protected function __($string, $args = [], $context = null);- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}Source https://phpmd.org/rules/naming.html#shortmethodname
The method __ is not named in camelCase. Invalid
Invalid
abstract protected function __($string, $args = [], $context = null);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}