Sign upLogin

Dhii/container-helper-base

View on GitHub
Star
src/ContainerUnsetCapableTrait.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function _containerUnset has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _containerUnset(&$container, $key)
    {
        $origKey = $key;
        $key     = $this->_normalizeKey($key);
Severity: Minor
Found in src/ContainerUnsetCapableTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _containerUnset has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _containerUnset(&$container, $key)
    {
        $origKey = $key;
        $key     = $this->_normalizeKey($key);
Severity: Minor
Found in src/ContainerUnsetCapableTrait.php - About 1 hr to fix

    Method _createNotFoundException has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Invalid

            $message = null,
        $code = null,
        RootException $previous = null,
        BaseContainerInterface $container = null,
        $dataKey = null
    Severity: Minor
    Found in src/ContainerUnsetCapableTrait.php - About 35 mins to fix

      Avoid unused local variables such as '$origKey'.
      Open

              $origKey = $key;
      Severity: Minor
      Found in src/ContainerUnsetCapableTrait.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid using short method names like ContainerUnsetCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/ContainerUnsetCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/ContainerUnsetCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status