Sign upLogin

Dhii/di-abstract

View on GitHub
Star

Showing 65 of 65 total issues

The method _set is not named in camelCase.
Open

    protected function _set($id, $definition = null)
    {
        if ($id instanceof BaseServiceProvider) {
            $this->_register($id);
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getCached is not named in camelCase.
Open

    protected function _getCached($id)
    {
        return isset($this->serviceCache[$id])
            ? $this->serviceCache[$id]
            : null;
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _isCached is not named in camelCase.
Open

    protected function _isCached($id)
    {
        return isset($this->serviceCache[$id]);
    }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _cacheService is not named in camelCase.
Open

    protected function _cacheService($id, $service)
    {
        $this->serviceCache[$id] = $service;

        return $this;
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _resolveDefinition is not named in camelCase.
Open

    protected function _resolveDefinition($definition, $config)
    {
        if (!is_callable($definition)) {
            throw $this->_createContainerException(sprintf('Could not resolve service definition": definition must be callable'));
        }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createContainerException is not named in camelCase.
Open

    abstract protected function _createContainerException($message, $code = 0, Exception $innerException = null);
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _make is not named in camelCase.
Open

    protected function _make($id, $config = array())
    {
        if (!($definition = $this->_getDefinition($id))) {
            throw $this->_createNotFoundException(sprintf('Could not create service for ID "%1$s": no service defined', $id));
        }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getServices is not named in camelCase.
Open

    protected function _getServices()
    {
        return $this->serviceDefinitions;
    }
Severity: Minor
Found in src/AbstractServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _hasDefinition is not named in camelCase.
Open

    protected function _hasDefinition($id)
    {
        return isset($this->serviceDefinitions[$id]);
    }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getRootContainer is not named in camelCase.
Open

    protected function _getRootContainer()
    {
        $parent = $this->_getParentContainer();
        do {
            $root = $parent;
Severity: Minor
Found in src/AbstractParentAwareContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getDefinition is not named in camelCase.
Open

    protected function _getDefinition($id)
    {
        return isset($this->serviceDefinitions[$id])
            ? $this->serviceDefinitions[$id]
            : null;
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _get is not named in camelCase.
Open

    protected function _get($id)
    {
        if ($this->_isCached($id)) {
            return $this->_getCached($id);
        }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setDefinition is not named in camelCase.
Open

    protected function _setDefinition($id, $definition)
    {
        $this->serviceDefinitions[$id] = $definition;

        return $this;
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createNotFoundException is not named in camelCase.
Open

    abstract protected function _createNotFoundException($message, $code = 0, Exception $innerException = null);
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _has is not named in camelCase.
Open

    protected function _has($id)
    {
        return $this->_hasDefinition($id);
    }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _register is not named in camelCase.
Open

    protected function _register(BaseServiceProvider $provider)
    {
        foreach ($provider->getServices() as $_id => $_definition) {
            $this->_setDefinition($_id, $_definition);
        }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getDefinitions is not named in camelCase.
Open

    protected function _getDefinitions()
    {
        return $this->serviceDefinitions;
    }
Severity: Minor
Found in src/AbstractContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setParentContainer is not named in camelCase.
Open

    protected function _setParentContainer(BaseContainerInterface $container = null)
    {
        $this->parentContainer = $container;

        return $this;
Severity: Minor
Found in src/AbstractParentAwareContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _add is not named in camelCase.
Open

    protected function _add($id, $definition)
    {
        // Checking only format, because the definition may become available later
        if (!is_callable($definition, true)) {
            throw $this->_createContainerException(
Severity: Minor
Found in src/AbstractServiceProvider.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _resolveDefinition is not named in camelCase.
Open

    protected function _resolveDefinition($definition, $config)
    {
        $root      = $this->_getRootContainer();
        $container = $root ? $root : $this;
Severity: Minor
Found in src/AbstractParentAwareContainer.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language