src/AbstractServiceProvider.php
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
protected function _add($id, $definition)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The variable $_definition is not named in camelCase. Open
Open
protected function _addMany($definitions)
{
foreach ($definitions as $_id => $_definition) {
$this->_add($_id, $_definition);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_definition is not named in camelCase. Open
Open
protected function _addMany($definitions)
{
foreach ($definitions as $_id => $_definition) {
$this->_add($_id, $_definition);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_id is not named in camelCase. Open
Open
protected function _addMany($definitions)
{
foreach ($definitions as $_id => $_definition) {
$this->_add($_id, $_definition);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_id is not named in camelCase. Open
Open
protected function _addMany($definitions)
{
foreach ($definitions as $_id => $_definition) {
$this->_add($_id, $_definition);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method _createContainerException is not named in camelCase. Open
Open
abstract protected function _createContainerException($message, $code = 0, \Exception $innerException = null);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _add is not named in camelCase. Open
Open
protected function _add($id, $definition)
{
// Checking only format, because the definition may become available later
if (!is_callable($definition, true)) {
throw $this->_createContainerException(- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _getServices is not named in camelCase. Open
Open
protected function _getServices()
{
return $this->serviceDefinitions;
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _addMany is not named in camelCase. Open
Open
protected function _addMany($definitions)
{
foreach ($definitions as $_id => $_definition) {
$this->_add($_id, $_definition);
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}