Sign upLogin

Dhii/iterator-abstract

View on GitHub
Star
src/IteratorAwareTrait.php

Summary

Maintainability
A
0 mins
Test Coverage

Property \Dhii\Iterator\IteratorAwareTrait->iterator has undeclared type \Dhii\Iterator\IteratorInterface
Open

    protected $iterator;
Severity: Minor
Found in src/IteratorAwareTrait.php by phan

Checking instanceof against undeclared class \Dhii\Iterator\IteratorInterface
Open

        if ($iterator !== null && !($iterator instanceof IteratorInterface)) {
Severity: Critical
Found in src/IteratorAwareTrait.php by phan

Parameter $iterator has undeclared type \Dhii\Iterator\IteratorInterface
Open

    protected function _setIterator($iterator)
Severity: Minor
Found in src/IteratorAwareTrait.php by phan

Parameter $message has undeclared type \Dhii\Util\String\StringableInterface
Open

    abstract protected function _createInvalidArgumentException(
Severity: Minor
Found in src/IteratorAwareTrait.php by phan

Return type of _getIterator() is undeclared type \Dhii\Iterator\IteratorInterface
Open

    protected function _getIterator()
Severity: Minor
Found in src/IteratorAwareTrait.php by phan

Avoid using short method names like IteratorAwareTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/IteratorAwareTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The method __ is not named in camelCase.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/IteratorAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getIterator is not named in camelCase.
Open

    protected function _getIterator()
    {
        return $this->iterator;
    }
Severity: Minor
Found in src/IteratorAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createInvalidArgumentException is not named in camelCase.
Open

    abstract protected function _createInvalidArgumentException(
        $message = null,
        $code = null,
        RootException $previous = null,
        $argument = null
Severity: Minor
Found in src/IteratorAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setIterator is not named in camelCase.
Open

    protected function _setIterator($iterator)
    {
        if ($iterator !== null && !($iterator instanceof IteratorInterface)) {
            throw $this->_createInvalidArgumentException(
                $this->__('Argument is not an iterator instance'),
Severity: Minor
Found in src/IteratorAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status