Sign upLogin

Dhii/iterator-base

View on GitHub
Star

Showing 12 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Dhii\Iterator\Exception;

use Dhii\Exception\CreateInvalidArgumentExceptionCapableTrait;
Severity: Major
Found in src/Exception/IterationException.php and 1 other location - About 4 hrs to fix
src/Exception/IteratorException.php on lines 1..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Dhii\Iterator\Exception;

use Dhii\Exception\CreateInvalidArgumentExceptionCapableTrait;
Severity: Major
Found in src/Exception/IteratorException.php and 1 other location - About 4 hrs to fix
src/Exception/IterationException.php on lines 1..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method _getPathSegments is not named in camelCase.
Open

    abstract protected function _getPathSegments();
Severity: Minor
Found in src/GetDepthCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createRecursiveIteration is not named in camelCase.
Open

    protected function _createRecursiveIteration($key, $value, $pathSegments = [])
    {
        return new RecursiveIteration($key, $value, $pathSegments);
    }
Severity: Minor
Found in src/CreateRecursiveIterationCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createIterationException is not named in camelCase.
Open

    protected function _createIterationException(
        $message = null,
        $code = null,
        RootException $previous = null,
        IterationInterface $iteration = null
Severity: Minor
Found in src/CreateIterationExceptionCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createIteratorException is not named in camelCase.
Open

    protected function _createIteratorException(
        $message = null,
        $code = null,
        RootException $previous = null,
        IteratorInterface $iterator
Severity: Minor
Found in src/CreateIteratorExceptionCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _countIterable is not named in camelCase.
Open

    abstract protected function _countIterable($iterable);
Severity: Minor
Found in src/GetDepthCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getPathSegments is not named in camelCase.
Open

    protected function _getPathSegments()
    {
        return is_null($this->pathSegments)
            ? []
            : $this->pathSegments;
Severity: Minor
Found in src/PathSegmentsAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createInvalidArgumentException is not named in camelCase.
Open

    abstract protected function _createInvalidArgumentException(
        $message = null,
        $code = null,
        RootException $previous = null,
        $argument = null
Severity: Minor
Found in src/PathSegmentsAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getDepth is not named in camelCase.
Open

    protected function _getDepth()
    {
        return $this->_countIterable($this->_getPathSegments()) - 1;
    }
Severity: Minor
Found in src/GetDepthCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeIterable is not named in camelCase.
Open

    abstract protected function _normalizeIterable($iterable);
Severity: Minor
Found in src/PathSegmentsAwareTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createIteratingException is not named in camelCase.
Open

    protected function _createIteratingException($message = null, $code = null, RootException $previous = null)
    {
        return new IteratingException($message, $code, $previous);
    }
Severity: Minor
Found in src/CreateIteratingExceptionCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language