Sign upLogin

Dhii/placeholder-template-abstract

View on GitHub
Star

Showing 4 of 4 total issues

Avoid using short method names like ReplaceTokensCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/ReplaceTokensCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method _replaceTokens has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function _replaceTokens($input, $source, $tokenStart, $tokenEnd, $default = null)
Severity: Minor
Found in src/ReplaceTokensCapableTrait.php - About 35 mins to fix

    Function _replaceTokens has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _replaceTokens($input, $source, $tokenStart, $tokenEnd, $default = null)
    {
        $input   = $this->_normalizeString($input);
        $default = $default === null ? '' : $this->_normalizeString($default);
    Severity: Minor
    Found in src/ReplaceTokensCapableTrait.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __ is not named in camelCase.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/ReplaceTokensCapableTrait.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    Severity
    Category
    Status
    Source
    Language