Sign upLogin

Dhii/regex-abstract

View on GitHub
Star
src/GetAllMatchesRegexCapablePcreTrait.php

Summary

Maintainability
A
0 mins
Test Coverage

Remove error control operator '@' on line 42.
Open

    protected function _getAllMatchesRegex($pattern, $subject)
    {
        $matches = [];
        $pattern = $this->_normalizeString($pattern);
        $subject = $this->_normalizeString($subject);
Severity: Minor
Found in src/GetAllMatchesRegexCapablePcreTrait.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Avoid using short method names like GetAllMatchesRegexCapablePcreTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/GetAllMatchesRegexCapablePcreTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The method __ is not named in camelCase.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/GetAllMatchesRegexCapablePcreTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status