Sign upLogin

Dhii/simple-test-abstract

View on GitHub
Star
src/Test/AbstractAggregator.php

Summary

Maintainability
A
1 hr
Test Coverage

Method _getCalculators has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
Severity: Minor
Found in src/Test/AbstractAggregator.php - About 1 hr to fix

    Function _getCalculators has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The variable $_status is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_status is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_status is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_status is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_status is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The method _getCalculators is not named in camelCase.
    Open

        protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
    Severity: Minor
    Found in src/Test/AbstractAggregator.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status