Sign upLogin

Dhii/simple-test-abstract

View on GitHub
Star
src/Test/AbstractResultSet.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class 'Dhii\SimpleTest\Test\AbstractResult' in method 'getTestStatusCodes'.
Open

        return AbstractResult::getAllTestStatusCodes();
Severity: Minor
Found in src/Test/AbstractResultSet.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _getAggregatableStatCodes is not named in camelCase.
Open

    protected function _getAggregatableStatCodes()
    {
        return array(
            'assertion_count',
            'time_usage',
Severity: Minor
Found in src/Test/AbstractResultSet.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _validateItem is not named in camelCase.
Open

    protected function _validateItem($item)
    {
        if (!($item instanceof ResultInterface)) {
            throw new UnexpectedValueException(sprintf('Item must be a valid test result'));
        }
Severity: Minor
Found in src/Test/AbstractResultSet.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status