Avoid excessively long variable names like $unsuccessfulTestCount. Keep variable name length under 20.

Open

        $unsuccessfulTestCount = $results->getTestCountByStatus(Test\AccountableInterface::TEST_FAILURE)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Method afterRunAllSuites has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function afterRunAllSuites(Test\ResultSetInterface $results, $source = null)
    {
        $writer = $this->_getWriter();

        // If we can't know what happened, finish

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct($caseName, $methodName, $key, $message, $status, $assertionCount, $suiteCode, $runnerCode, $time, $memory)

Method _createResultFromTest has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    protected function _createResultFromTest(Test\TestBaseInterface $test, $message, $status, $assertionCount, $runnerCode, $time, $memory)

Avoid variables with short names like $i. Configured minimum length is 3.

Open

        $i     = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Function _getTestMessageText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    protected function _getTestMessageText(Test\ResultInterface $test)
    {
        $message = $test->getMessage();
        if ($message instanceof \Exception) {
            if ($test->isSuccessful()) {

• Read up
  Read up

Missing class import via use statement (line '35', column '20').

Open

        return new \AppendIterator();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.

Open

    public function __construct($caseName, $methodName, $key, $message, $status, $assertionCount, $suiteCode, $runnerCode, $time, $memory)
    {
        $this->_setCaseName($caseName)
                ->_setMethodName($methodName)
                ->_setKey($key);

• Exclude checks
  • Disable engine
  • Disable check

Avoid unused parameters such as '$source'.

Open

    public function afterRunAllSuites(Test\ResultSetInterface $results, $source = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$source'.

Open

    public function beforeRunTest(Test\TestInterface $test, $source = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$source'.

Open

    public function afterRunTest(Test\ResultInterface $result, $source = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

The method _createAssertionMaker is not named in camelCase.

Open

    protected function _createAssertionMaker()
    {
        return new Assertion\Maker();
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _humanSize is not named in camelCase.

Open

    protected function _humanSize($size, $precision = 2)
    {
        $units = array('B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB');
        $step  = 1024;
        $i     = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _createSearchResultsIterator is not named in camelCase.

Open

    protected function _createSearchResultsIterator($results)
    {
        $class    = 'Dhii\SimpleTest\Test\ResultSet';
        $instance = new $class(array(), $this->_getStatAggregator());
        /* @var $instance AbstractSearchableCollection */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _matchMethod is not named in camelCase.

Open

    protected function _matchMethod(\ReflectionMethod $method)
    {
        return $this->_stringStartsWith($method->getName(), 'test');
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _createTest is not named in camelCase.

Open

    protected function _createTest($className, $methodName, $key)
    {
        return new Test\Test($className, $methodName, $key);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _createClassLocator is not named in camelCase.

Open

    protected function _createClassLocator($className)
    {
        $locator = new ClassLocator();
        $locator->setClass($className);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _createInnerIterator is not named in camelCase.

Open

    protected function _createInnerIterator()
    {
        return new \AppendIterator();
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _createSuite is not named in camelCase.

Open

    protected function _createSuite($code, Coordinator\CoordinatorInterface $coordinator)
    {
        return new Suite\Suite($code, $coordinator);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method _validateItem is not named in camelCase.

Open

    protected function _validateItem($item)
    {
        if (!($item instanceof ResultSetInterface)) {
            throw new UnexpectedValueException(sprintf('Item must be a valid test result set'));
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}