Sign upLogin

Dhii/simple-test

View on GitHub
Star

Showing 40 of 40 total issues

Avoid excessively long variable names like $unsuccessfulTestCount. Keep variable name length under 20.
Open

        $unsuccessfulTestCount = $results->getTestCountByStatus(Test\AccountableInterface::TEST_FAILURE)
Severity: Minor
Found in src/Coordinator/Coordinator.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method afterRunAllSuites has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function afterRunAllSuites(Test\ResultSetInterface $results, $source = null)
    {
        $writer = $this->_getWriter();

        // If we can't know what happened, finish
Severity: Minor
Found in src/Coordinator/Coordinator.php - About 1 hr to fix

    Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($caseName, $methodName, $key, $message, $status, $assertionCount, $suiteCode, $runnerCode, $time, $memory)
    Severity: Major
    Found in src/Test/Result.php - About 1 hr to fix

      Method _createResultFromTest has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function _createResultFromTest(Test\TestBaseInterface $test, $message, $status, $assertionCount, $runnerCode, $time, $memory)
      Severity: Major
      Found in src/Runner/Runner.php - About 50 mins to fix

        Avoid variables with short names like $i. Configured minimum length is 3.
        Open

                $i     = 0;
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Function _getTestMessageText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function _getTestMessageText(Test\ResultInterface $test)
    {
        $message = $test->getMessage();
        if ($message instanceof \Exception) {
            if ($test->isSuccessful()) {
        Severity: Minor
        Found in src/Coordinator/Coordinator.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Missing class import via use statement (line '35', column '20').
        Open

                return new \AppendIterator();
        Severity: Minor
        Found in src/Test/ResultSetCollection.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
        Open

            public function __construct($caseName, $methodName, $key, $message, $status, $assertionCount, $suiteCode, $runnerCode, $time, $memory)
    {
        $this->_setCaseName($caseName)
                ->_setMethodName($methodName)
                ->_setKey($key);
        Severity: Minor
        Found in src/Test/Result.php by phpmd

        Avoid unused parameters such as '$source'.
        Open

            public function afterRunAllSuites(Test\ResultSetInterface $results, $source = null)
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused parameters such as '$source'.
        Open

            public function afterRunTest(Test\ResultInterface $result, $source = null)
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused parameters such as '$source'.
        Open

            public function beforeRunTest(Test\TestInterface $test, $source = null)
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        The method _getWriter is not named in camelCase.
        Open

            protected function _getWriter()
    {
        return $this->writer;
    }
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _validateItem is not named in camelCase.
        Open

            protected function _validateItem($item)
    {
        if (!($item instanceof Test\TestInterface)) {
            throw new InvalidArgumentException(sprintf('Not a valid test'));
        }
        Severity: Minor
        Found in src/Locator/ResultSet.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _createSearchResultsIterator is not named in camelCase.
        Open

            protected function _createSearchResultsIterator($results)
    {
        $class    = get_class($this);
        $instance = new $class(array(), $this->_getStatAggregator());
        /* @var $instance AbstractSearchableCollection */
        Severity: Minor
        Found in src/Test/ResultSet.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _createResultSet is not named in camelCase.
        Open

            protected function _createResultSet($items)
    {
        return new ResultSet($items);
    }
        Severity: Minor
        Found in src/Locator/FilePathLocator.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _write is not named in camelCase.
        Open

            public function _write($text)
    {
        echo $text;

        return $this;
        Severity: Minor
        Found in src/Writer/Writer.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _matchMethod is not named in camelCase.
        Open

            protected function _matchMethod(\ReflectionMethod $method)
    {
        return $this->_stringStartsWith($method->getName(), 'test');
    }
        Severity: Minor
        Found in src/Locator/ClassLocator.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _getTestMessageText is not named in camelCase.
        Open

            protected function _getTestMessageText(Test\ResultInterface $test)
    {
        $message = $test->getMessage();
        if ($message instanceof \Exception) {
            if ($test->isSuccessful()) {
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _createStatAggregator is not named in camelCase.
        Open

            protected function _createStatAggregator()
    {
        return new Test\Aggregator();
    }
        Severity: Minor
        Found in src/Tester/Tester.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        The method _any is not named in camelCase.
        Open

            protected function _any($target, $data = null, $source = null)
    {
        parent::_any($target, $data, $source);
    }
        Severity: Minor
        Found in src/Coordinator/Coordinator.php by phpmd

        CamelCaseMethodName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name methods.

        Example

        class ClassName {
    public function get_name() {
    }
}

        Source

        Severity
        Category
        Status
        Source
        Language