Dhii/simple-test

View on GitHub

Showing 4 of 40 total issues

Method afterRunAllSuites has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function afterRunAllSuites(Test\ResultSetInterface $results, $source = null)
    {
        $writer = $this->_getWriter();

        // If we can't know what happened, finish
Severity: Minor
Found in src/Coordinator/Coordinator.php - About 1 hr to fix

    Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($caseName, $methodName, $key, $message, $status, $assertionCount, $suiteCode, $runnerCode, $time, $memory)
    Severity: Major
    Found in src/Test/Result.php - About 1 hr to fix

      Method _createResultFromTest has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function _createResultFromTest(Test\TestBaseInterface $test, $message, $status, $assertionCount, $runnerCode, $time, $memory)
      Severity: Major
      Found in src/Runner/Runner.php - About 50 mins to fix

        Function _getTestMessageText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function _getTestMessageText(Test\ResultInterface $test)
            {
                $message = $test->getMessage();
                if ($message instanceof \Exception) {
                    if ($test->isSuccessful()) {
        Severity: Minor
        Found in src/Coordinator/Coordinator.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language