Dhii/validation-base

View on GitHub

Showing 15 of 21 total issues

Method _createValidationFailedException has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $message = null,
        $code = null,
        RootException $previous = null,
        ValidatorInterface $validator = null,
        $subject = null,
Severity: Minor
Found in src/CreateValidationFailedExceptionCapableTrait.php - About 45 mins to fix

    Method _throwValidationFailedException has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $message = null,
            $code = null,
            RootException $previous = null,
            $validator = null,
            $subject = null,
    Severity: Minor
    Found in src/AbstractValidatorBase.php - About 45 mins to fix

      Function _createValidationFailedException has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _createValidationFailedException(
              $message = null,
              $code = null,
              RootException $previous = null,
              ValidatorInterface $validator = null,
      Severity: Minor
      Found in src/CreateValidationFailedExceptionCapableTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused local variables such as '$_idx'.
      Open

                      foreach ($validationErrors as $_idx => $error) {

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      The variable $_idx is not named in camelCase.
      Open

          protected function _createValidationFailedException(
              $message = null,
              $code = null,
              RootException $previous = null,
              ValidatorInterface $validator = null,

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The method _construct is not named in camelCase.
      Open

          protected function _construct()
          {
          }

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _throwValidationFailedException is not named in camelCase.
      Open

          protected function _throwValidationFailedException(
              $message = null,
              $code = null,
              RootException $previous = null,
              $validator = null,
      Severity: Minor
      Found in src/AbstractValidatorBase.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _createValidationException is not named in camelCase.
      Open

          protected function _createValidationException($message = null, $code = null, RootException $previous = null, ValidatorInterface $validator = null)
          {
              return new ValidationException($message, $code, $previous, $validator);
          }

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _construct is not named in camelCase.
      Open

          protected function _construct()
          {
          }
      Severity: Minor
      Found in src/AbstractValidatorBase.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _normalizeIterable is not named in camelCase.
      Open

          abstract protected function _normalizeIterable($iterable);

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _construct is not named in camelCase.
      Open

          protected function _construct()
          {
          }

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _initParent is not named in camelCase.
      Open

          protected function _initParent($message = '', $code = 0, RootException $previous = null)
          {
              parent::__construct($message, $code, $previous);
          }

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _createValidationFailedException is not named in camelCase.
      Open

          protected function _createValidationFailedException(
              $message = null,
              $code = null,
              RootException $previous = null,
              ValidatorInterface $validator = null,

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _normalizeString is not named in camelCase.
      Open

          abstract protected function _normalizeString($subject);

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      The method _throwValidationException is not named in camelCase.
      Open

          protected function _throwValidationException(
              $message = null,
              $code = null,
              RootException $previous = null,
              $validator = null
      Severity: Minor
      Found in src/AbstractValidatorBase.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
          public function get_name() {
          }
      }

      Source

      Severity
      Category
      Status
      Source
      Language