src/CreateEventCapableTrait.php
The method _createEvent has a boolean flag argument $propagation, which is a certain sign of a Single Responsibility Principle violation. Open
Open
protected function _createEvent($name, $params = [], $target = null, $propagation = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method _createEvent is not named in camelCase. Open
Open
protected function _createEvent($name, $params = [], $target = null, $propagation = true)
{
return new Event($name, $params, $target, $propagation);
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}