Sign upLogin

Dhii/wp-events

View on GitHub
Star
src/Event.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has a boolean flag argument $propagation, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($name, array $params = [], $target = null, $propagation = true)
Severity: Minor
Found in src/Event.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The 'getPropagation()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getPropagation()
    {
        return $this->propagation;
    }
Severity: Minor
Found in src/Event.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

There are no issues that match your filters.

Category
Status