Sign upLogin

Dhii/wp-events

View on GitHub
Star
src/NormalizeEventCapableTrait.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _createEvent has a boolean flag argument $propagation, which is a certain sign of a Single Responsibility Principle violation.
Open

    abstract protected function _createEvent($name, $params = [], $target = null, $propagation = true);
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using short method names like NormalizeEventCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The method __ is not named in camelCase.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeEvent is not named in camelCase.
Open

    protected function _normalizeEvent($event, $params = [], $target = null)
    {
        if (is_string($event) || $event instanceof Stringable) {
            return $this->_createEvent($this->_normalizeString($event), $params, $target);
        }
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createInvalidArgumentException is not named in camelCase.
Open

    abstract protected function _createInvalidArgumentException(
        $message = null,
        $code = null,
        RootException $previous = null,
        $argument = null
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeString is not named in camelCase.
Open

    abstract protected function _normalizeString($subject);
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createEvent is not named in camelCase.
Open

    abstract protected function _createEvent($name, $params = [], $target = null, $propagation = true);
Severity: Minor
Found in src/NormalizeEventCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status