The method _createWpHandlerWrapper has a boolean flag argument $throwOnPropStop, which is a certain sign of a Single Responsibility Principle violation. Open
protected function _createWpHandlerWrapper($name, $callback, $throwOnPropStop = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method _createWpHandlerWrapper uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// Creates and retrieves an instance if an event name
$event = $eventCache->_getCachedEvent($name, $fnArgs);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using short method names like CreateWpHandlerWrapperCapableTrait::__(). The configured minimum method name length is 3. Open
abstract protected function __($string, $args = [], $context = null);- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}Source https://phpmd.org/rules/naming.html#shortmethodname
The method _createStoppedPropagationException is not named in camelCase. Open
abstract protected function _createStoppedPropagationException(
$message = null,
$code = null,
$previous = null,
$event = null- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method __ is not named in camelCase. Open
abstract protected function __($string, $args = [], $context = null);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _createWpHandlerWrapper is not named in camelCase. Open
protected function _createWpHandlerWrapper($name, $callback, $throwOnPropStop = false)
{
$eventCache = $this;
/*- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _getCachedEvent is not named in camelCase. Open
abstract protected function _getCachedEvent($name, array $args = []);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}