Discord-InterChat/InterChat

View on GitHub
src/commands/slash/Main/connection/edit.ts

Summary

Maintainability
C
1 day
Test Coverage

File edit.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Constants, { emojis } from '#utils/Constants.js';
import { RegisterInteractionHandler } from '#main/decorators/RegisterInteractionHandler.js';
import { isGuildTextBasedChannel } from '#utils/ChannelUtls.js';
import { setComponentExpiry } from '#utils/ComponentUtils.js';
import { updateConnection } from '#utils/ConnectedListUtils.js';
Severity: Minor
Found in src/commands/slash/Main/connection/edit.ts - About 2 hrs to fix

    Function handleModals has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      @RegisterInteractionHandler('connectionModal')
      async handleModals(interaction: ModalSubmitInteraction): Promise<void> {
        const customId = CustomID.parseCustomId(interaction.customId);
        const locale = await this.getLocale(interaction);
    
    
    Severity: Minor
    Found in src/commands/slash/Main/connection/edit.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleStringSelects has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      @RegisterInteractionHandler('connection')
      async handleStringSelects(interaction: StringSelectMenuInteraction) {
        if (!interaction.isStringSelectMenu()) return;
    
        const customId = CustomID.parseCustomId(interaction.customId);
    Severity: Minor
    Found in src/commands/slash/Main/connection/edit.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleChannelSelects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      @RegisterInteractionHandler('connection', 'change_channel')
      async handleChannelSelects(interaction: ChannelSelectMenuInteraction) {
        if (!interaction.isChannelSelectMenu()) return;
        await interaction.deferUpdate();
    
    
    Severity: Minor
    Found in src/commands/slash/Main/connection/edit.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            const modal = new ModalBuilder()
              .setTitle('Add Invite Link')
              .setCustomId(
                new CustomID().setIdentifier('connectionModal', 'invite').addArgs(channelId).toString(),
              )
    Severity: Minor
    Found in src/commands/slash/Main/connection/edit.ts and 1 other location - About 50 mins to fix
    src/commands/slash/Main/connection/edit.ts on lines 203..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            const modal = new ModalBuilder()
              .setTitle('Set Embed Color')
              .setCustomId(
                new CustomID()
                  .setIdentifier('connectionModal', 'embed_color')
    Severity: Minor
    Found in src/commands/slash/Main/connection/edit.ts and 1 other location - About 50 mins to fix
    src/commands/slash/Main/connection/edit.ts on lines 183..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if (!channelId || !connection) {
          await interaction.reply({
            content: t('connection.channelNotFound', locale, { emoji: emojis.no }),
            ephemeral: true,
          });
    Severity: Major
    Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
    src/commands/slash/Main/connection/edit.ts on lines 93..99
    src/commands/slash/Main/connection/edit.ts on lines 111..117
    src/commands/slash/Main/hub/invite.ts on lines 91..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          if (!Constants.Regex.Hexcode.test(embedColor)) {
            await interaction.reply({
              content: t('connection.emColorInvalid', locale, { emoji: emojis.no }),
              ephemeral: true,
            });
    Severity: Major
    Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
    src/commands/slash/Main/connection/edit.ts on lines 93..99
    src/commands/slash/Main/connection/edit.ts on lines 165..171
    src/commands/slash/Main/hub/invite.ts on lines 91..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          if (fetchedInvite?.guild?.id !== interaction.guildId) {
            await interaction.followUp({
              content: t('connection.inviteInvalid', locale, { emoji: emojis.no }),
              ephemeral: true,
            });
    Severity: Major
    Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
    src/commands/slash/Main/connection/edit.ts on lines 111..117
    src/commands/slash/Main/connection/edit.ts on lines 165..171
    src/commands/slash/Main/hub/invite.ts on lines 91..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status