Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star
app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java

Summary

Maintainability
C
7 hrs
Test Coverage
C
77%

Method onCreate has 158 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    @SuppressLint({"MissingInflatedId", "NonConstantResourceId"})
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java - About 6 hrs to fix

    File MainHomeActivity.java has 341 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.github.siela1915.bootcamp;

import android.annotation.SuppressLint;
import android.app.AlertDialog;
import android.content.Intent;
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java - About 4 hrs to fix

      Method onCreate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          @SuppressLint({"MissingInflatedId", "NonConstantResourceId"})
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method openHelp has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private void openHelp() {
        Bundle extras = getIntent().getExtras();
        navigationView.setCheckedItem(R.id.menuItem_help);
        Intent intent = new Intent(this, MainHomeActivity.class);
        if (extras != null) {
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Invalid

              cuisineBtn.setOnClickListener(v -> {
            String [] cuisineTypes= CuisineType.getAll();
            boolean[] checksum= new boolean[cuisineTypes.length];
            String title = "Choose your preferred cuisine";
            popUpDialogBuilder(cuisineTypes,checksum,title,selectedCuisine);
      Severity: Major
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 3 other locations - About 45 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 101..106
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 107..112
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 113..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Invalid

              timeBtn.setOnClickListener(v -> {
            String [] prepTime= PreparationTime.getAll();
            boolean[] checksum= new boolean[prepTime.length];
            String title = "Choose the preparation time";
            popUpDialogBuilder(prepTime,checksum,title,selectedPrepTime);
      Severity: Major
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 3 other locations - About 45 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 94..99
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 101..106
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 113..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Invalid

              dietBtn.setOnClickListener(v -> {
            String [] diets= DietType.getAll();
            boolean[] checksum= new boolean[diets.length];
            String title = "Choose your diet";
            popUpDialogBuilder(diets,checksum,title,selectedDiet);
      Severity: Major
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 3 other locations - About 45 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 94..99
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 107..112
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 113..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Invalid

              allergyBtn.setOnClickListener(v -> {
            String [] allergies= AllergyType.getAll();
            boolean[] checksum= new boolean[allergies.length];
            String title = "what are you allergic to";
            popUpDialogBuilder(allergies,checksum,title,selectedAllery);
      Severity: Major
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 3 other locations - About 45 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 94..99
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 101..106
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 107..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              builder.setNegativeButton("Cancel", (dialog, which) -> {
            for(int i= 0; i< checksum.length; i++){
                checksum[i]=false;
            }
            dialog.cancel();
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 1 other location - About 40 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/HomePageFragment.java on lines 327..332

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Wontfix

                      case R.id.menuItem_login:
                    intent.putExtra("com.github.siela1915.bootcamp.navToProfile", true);
                    if (FirebaseAuthActivity.promptLogin(this, this, intent)) {
                        setContainerContent(R.id.fragContainer, ProfileFragment.class, false);
                    }
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 2 other locations - About 40 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 177..182
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 183..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Wontfix

                      case R.id.menuItem_fridge:
                    intent.putExtra("navToMyFridge", true);
                    if (FirebaseAuthActivity.promptLogin(this, this, intent)) {
                        setContainerContent(R.id.fragContainer, MyFridgeFragment.class, false);
                    }
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 2 other locations - About 40 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 171..176
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 177..182

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Wontfix

                      case R.id.menuItem_upload:
                    intent.putExtra("navToUpload", true);
                    if (FirebaseAuthActivity.promptLogin(this, this, intent)) {
                        setContainerContent(R.id.fragContainer, UploadingRecipeFragment.class, false);
                    }
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 2 other locations - About 40 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 171..176
      app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java on lines 183..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              dialog.setOnShowListener(arg0 -> {
            dialog.getButton(AlertDialog.BUTTON_NEGATIVE).setTextColor(R.color.teal_700);
            dialog.getButton(AlertDialog.BUTTON_POSITIVE).setTextColor(R.color.teal_700);
        });
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/MainHomeActivity.java and 1 other location - About 35 mins to fix
      app/src/main/java/com/github/siela1915/bootcamp/HomePageFragment.java on lines 335..338

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status