Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star
app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java

Summary

Maintainability
C
7 hrs
Test Coverage
D
65%

File NearbyHelpFragment.java has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.github.siela1915.bootcamp;

import static android.content.Context.LAYOUT_INFLATER_SERVICE;
import static com.google.android.gms.location.Priority.PRIORITY_BALANCED_POWER_ACCURACY;
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java - About 2 hrs to fix

    Method onMapReady has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SuppressLint("MissingPermission")
    @Override
    public void onMapReady(@NonNull GoogleMap googleMap) {
        googleMap.setOnInfoWindowClickListener(this);
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java - About 1 hr to fix

      Method onInfoWindowClick has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    public void onInfoWindowClick(@NonNull Marker marker) {
        Pair<String, Ingredient> offer = offers.get(marker);
        FirebaseUser user = FirebaseInstanceManager.getAuth().getCurrentUser();
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                                if (offer.getUnit().getValue() >= asked.getUnit().getValue()) {
                                            color = BitmapDescriptorFactory.defaultMarker(BitmapDescriptorFactory.HUE_GREEN);
                                        } else {
                                            color = BitmapDescriptorFactory.defaultMarker(BitmapDescriptorFactory.HUE_ORANGE);
                                        }
        Severity: Major
        Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java - About 45 mins to fix

          Method onCreate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        askLocationPermission();
        askNotificationPermission();
          Severity: Minor
          Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static NearbyHelpFragment newInstance(List<Ingredient> askedIngredients) {
        NearbyHelpFragment fragment = new NearbyHelpFragment();
        Bundle args = new Bundle();
        args.putParcelableArrayList(ARG_ASKED_INGREDIENTS, new ArrayList<>(askedIngredients));
        fragment.setArguments(args);
          Severity: Minor
          Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java and 2 other locations - About 35 mins to fix
          app/src/main/java/com/github/siela1915/bootcamp/HomePageFragment.java on lines 90..96
          app/src/main/java/com/github/siela1915/bootcamp/RecipeListFragment.java on lines 36..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static NearbyHelpFragment newInstance(Ingredient askedIngredient) {
        NearbyHelpFragment fragment = new NearbyHelpFragment();
        Bundle args = new Bundle();
        args.putParcelable(ARG_ASKED_INGREDIENT, askedIngredient);
        fragment.setArguments(args);
          Severity: Minor
          Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java and 1 other location - About 30 mins to fix
          app/src/main/java/com/github/siela1915/bootcamp/FragmentIngredientCheckContainer.java on lines 35..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status