Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star
app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java

Summary

Maintainability
C
7 hrs
Test Coverage
A
92%

Method setPageContents has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void setPageContents() {

        ImageView recipePicture = (ImageView) findViewById(R.id.recipePicture);
        TextView recipeNameText = (TextView) findViewById(R.id.recipeNameText);
        ImageView userAvatar = (ImageView) findViewById(R.id.userAvatar);
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java - About 2 hrs to fix

    Method onCheckedChanged has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
        if (isChecked) {

            // Add the recipe to favorites
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java - About 1 hr to fix

      Method setCommentContents has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void setCommentContents(RecyclerView commentsList) {

        commentsList.setLayoutManager(new LinearLayoutManager(this));
        for(Comment c : recipe.comments){
            c.setContent(LanguageFilter.filterLanguage(c.getContent()));
      Severity: Minor
      Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java - About 1 hr to fix

        Method onCreate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_recipe);
        Severity: Minor
        Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      database.addFavorite(recipe.uniqueKey).addOnSuccessListener(arg -> {
                // Show a success message to the user
                Toast.makeText(this, "Recipe added to favorites", Toast.LENGTH_SHORT).show();

                //change background
          Severity: Minor
          Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java and 1 other location - About 55 mins to fix
          app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java on lines 327..340

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      database.removeFavorite(recipe.uniqueKey).addOnSuccessListener(s -> {

                // display success message
                Toast.makeText(this, "Recipe removed from favorites", Toast.LENGTH_SHORT).show();
          Severity: Minor
          Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java and 1 other location - About 55 mins to fix
          app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java on lines 301..312

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status