Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java

Summary

Maintainability
B
4 hrs
Test Coverage
A
97%

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static AllergyType getDominantAllergy(List<Recipe> ls) {
        int[] arr = new int[AllergyType.values().length];
        for (Recipe elem : ls) {
            elem.getAllergyTypes().forEach(allergy -> ++arr[allergy]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 103..109
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static DietType getDominantDiet(List<Recipe> ls) {
        int[] arr = new int[DietType.values().length];
        for (Recipe elem : ls) {
            elem.getDietTypes().forEach(diet -> ++arr[diet]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 89..95
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static CuisineType getDominantCuisine(List<Recipe> ls) {
        int[] arr = new int[CuisineType.values().length];
        for (Recipe elem : ls) {
            elem.getCuisineTypes().forEach(cuisine -> ++arr[cuisine]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 89..95
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 103..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static List<Recipe> getCuisine(CuisineType cuisine, List<Recipe> ls) {
        return ls.stream().filter(r -> r.getCuisineTypes() != null && r.getCuisineTypes().contains(cuisine.ordinal()))
                .collect(Collectors.toList());
    }
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 20..23
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static List<Recipe> getDiet(DietType diet, List<Recipe> ls) {
        return ls.stream().filter(r -> r.getDietTypes() != null && r.getDietTypes().contains(diet.ordinal()))
                .collect(Collectors.toList());
    }
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 20..23
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 42..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static List<Recipe> getAllergy(AllergyType allergy, List<Recipe> ls) {
        return ls.stream().filter(r -> r.getAllergyTypes() != null && r.getAllergyTypes().contains(allergy.ordinal()))
                .collect(Collectors.toList());
    }
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 31..34
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 42..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status