Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star

Showing 92 of 120 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else {
                addToListButton.setBackground(ContextCompat.getDrawable(itemView.getContext(), R.drawable.ic_plus_circle_full));
                addToListButton.setTag("removed");
                shoppingListManager.removeIngredient(ingredientName.getText().toString());
            }
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/IngredientViewHolder.java and 1 other location - About 30 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/IngredientViewHolder.java on lines 27..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                timerOnDisplay = new CountDownTimer(countDownTimerWithPause.getRemainingTime(), countDownTimerWithPause.getCountdownInterval()) {

                    @Override
                    public void onTick(long millisUntilFinished) {
                        remainingTime.setText(Time.milliSecToString(millisUntilFinished));
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/CookNowTimerFragment.java and 1 other location - About 30 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/TimerEditorDialog.java on lines 101..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            CountDownTimer timerToBeDisplayedOnList = new CountDownTimer(countDownTimerWithPause.getRemainingTime(), countDownTimerWithPause.getCountdownInterval()) {
                @Override
                public void onTick(long millisUntilFinished) {
                    timerRemainingTime.setText(Time.milliSecToString(millisUntilFinished));
                }
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/TimerEditorDialog.java and 1 other location - About 30 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/CookNowTimerFragment.java on lines 59..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Recipes/Comment.java - About 30 mins to fix

    Method onSignInResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private void onSignInResult(FirebaseAuthUIAuthenticationResult result) {
        IdpResponse response = result.getIdpResponse();
        if (result.getResultCode() == RESULT_OK) {
            // Successfully signed in
            FirebaseUser user = FirebaseInstanceManager.getAuth().getCurrentUser();
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/FirebaseAuthActivity.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public boolean equals(Object obj) {
        if (obj instanceof Utensils) {
            for (String u : ((Utensils) obj).utensils) {
                if (!utensils.contains(u)) {
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/Recipes/Utensils.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addIngredient has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public void addIngredient(Map<String, Integer> idMap, IngredientAutocomplete apiService, boolean offerable, List<String> prefill) {
        if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.O) {
            final View ingredient = inflater.inflate(R.layout.recipe_ingredient_edittext, null, false);
            ImageView removeIngredient = (ImageView) ingredient.findViewById(R.id.removeIngredient);
            ImageView offerIngredient = (ImageView) ingredient.findViewById(R.id.offerIngredientItem);
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/UploadRecipe/RecipeStepAndIngredientManager.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getOfferable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public List<Integer> getOfferable() {
        ArrayList<Integer> ingredients = new ArrayList<>();
        for (int i = 0; i < ingredientLinearLayout.getChildCount(); i++) {
            if (ingredientLinearLayout.getChildAt(i) instanceof ConstraintLayout) {
                ConstraintLayout step = (ConstraintLayout) ingredientLinearLayout.getChildAt(i);
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/UploadRecipe/RecipeStepAndIngredientManager.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getSteps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public List<String> getSteps() {
        ArrayList<String> steps = new ArrayList<String>();
        for (int i = 0; i < stepListLinearLayout.getChildCount(); i++) {
            if (stepListLinearLayout.getChildAt(i) instanceof ConstraintLayout) {
                ConstraintLayout step = (ConstraintLayout) stepListLinearLayout.getChildAt(i);
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/UploadRecipe/RecipeStepAndIngredientManager.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetchRecipeList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public List<String> fetchRecipeList(){
        //String will represent the ID of the recipe, for now it's just the name
        Map<String, Float> mapOfRecipes = new HashMap<>();

        for(Recipe r :allRecipes){
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method transformPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public void transformPage(View view, float position) {
        int pageWidth = view.getWidth();
        int pageHeight = view.getHeight();

        if (position < -1 || position > 1) { // [-Infinity,-1)
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/ZoomOutPageTransformer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getTypes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private List<Integer> getTypes(LinearLayout typeLayout, Object[] typeValues) {
        ArrayList<Integer> types = new ArrayList<Integer>();
        for (int i = 0; i < typeLayout.getChildCount(); i++) {
            if (typeLayout.getChildAt(i) instanceof ConstraintLayout) {
                ConstraintLayout type = (ConstraintLayout) typeLayout.getChildAt(i);
    Severity: Minor
    Found in app/src/main/java/com/github/siela1915/bootcamp/UploadRecipe/UploadingRecipeFragment.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language