Sign upLogin

DmitryTsepelev/ar_lazy_preload

View on GitHub
Star

Showing 4 of 4 total issues

Method run has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    setup_data

    without_gc do
      run_with_memory_report("AR eager loading w/ 100% usage: ") do
Severity: Major
Found in benchmark/memory.rb - About 2 hrs to fix

    Method run_bench has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_bench(x, usage_percent:, auto_preload: nil)
    label =
      case auto_preload
      when nil then "AR eager loading"
      when false then "AR lazy preloading w/o auto_preload"
    Severity: Minor
    Found in benchmark/main.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def perform
      associated_records = parent_context.records.flat_map do |record|
        next if record.nil?

        reflection = reflection_cache[record.class]
    Severity: Minor
    Found in lib/ar_lazy_preload/associated_context_builder.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method preloadable_reflection? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def preloadable_reflection?(klass, reflection)
        scope = reflection.scope
        preloadable_scope = scope&.arity&.zero? || ::ActiveRecord::VERSION::MAJOR >= 7
        through_reflection =
          reflection.options[:through] && klass.reflect_on_association(reflection.options[:through])
    Severity: Minor
    Found in lib/ar_lazy_preload/contexts/base_context.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language