Sign upLogin

Dopamedia/StateMachine

View on GitHub
Star
Model/Process/Process.php

Summary

Maintainability
A
2 hrs
Test Coverage

Process has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Process implements ProcessProcessInterface
{
    /**
     * @var string
     */
Severity: Minor
Found in Model/Process/Process.php - About 2 hrs to fix

    Function getManualEvents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getManualEvents()
    {
        $manuallyExecutableEventList = [];
        $transitions = $this->getAllTransitions();
        foreach ($transitions as $transition) {
    Severity: Minor
    Found in Model/Process/Process.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$processes' which will lead to PHP notices.
    Open

            return $processes;
    Severity: Minor
    Found in Model/Process/Process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$processes' which will lead to PHP notices.
    Open

            $processes[] = $this;
    Severity: Minor
    Found in Model/Process/Process.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid excessively long variable names like $manuallyExecutableEventList. Keep variable name length under 20.
    Open

            $manuallyExecutableEventList = [];
    Severity: Minor
    Found in Model/Process/Process.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status