Sign upLogin

DoubleCheck/postfix-parser

View on GitHub
Star

Showing 13 of 13 total issues

File index.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var logger = require('./lib/logger');

var envEmailAddr   = '<?([^>,]*)>?';
Severity: Minor
Found in index.js - About 2 hrs to fix

    Function smtpAsObject has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function smtpAsObject (line) {
  var match = line.match(regex.smtp);
  if (match) return matchAsObject(match);

  match = line.match(regex['smtp-conn-err']);
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {

  grunt.loadNpmTasks('grunt-eslint');
  grunt.loadNpmTasks('grunt-mocha-test');
  grunt.loadNpmTasks('grunt-version-check');
      Severity: Minor
      Found in Gruntfile.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          error: new RegExp(
       '^(?:(' + postfixQidAny + '): )?' +
       '(to)=' + envEmailAddr + ', ' +
       '(?:(orig_to)=' + envEmailAddr + ', )?' +
       '(relay)=([^,]+), ' +
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 109..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          local: new RegExp(
       '^(?:(' + postfixQidAny + '): )?' +
       '(to)=' + envEmailAddr + ', ' +
       '(?:(orig_to)=' + envEmailAddr + ', )?' +
       '(relay)=([^,]+), ' +
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 83..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function asObjectType has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.asObjectType = function (type, line) {
  if (!type || !line) {
    logger.error('missing required arg');
    return;
  }
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function smtpAsObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function smtpAsObject (line) {
  var match = line.match(regex.smtp);
  if (match) return matchAsObject(match);

  match = line.match(regex['smtp-conn-err']);
          Severity: Minor
          Found in index.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return {
      qid: match[1],
      msg: match[2],
    };
          Severity: Major
          Found in index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (!match) return;
            Severity: Major
            Found in index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return { msg: match[0] };
              Severity: Major
              Found in index.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return {
      action: 'defer',
      qid: match[1],
      host: match[2],
      msg: match[3],
                Severity: Major
                Found in index.js - About 30 mins to fix

                  Function asObjectType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.asObjectType = function (type, line) {
  if (!type || !line) {
    logger.error('missing required arg');
    return;
  }
                  Severity: Minor
                  Found in index.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function matchAsObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function matchAsObject (match) {
  match.shift();
  var obj = {};
  var qid = match.shift();
  if (qid) obj.qid = qid;
                  Severity: Minor
                  Found in index.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language