src/Vies/Validator/ValidatorNL.php
Avoid too many return statements within this method. Open
Open
return ((int) $sumBase % 97) === 1;The method validateSoleProprietor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return ((int) $sumBase % 97) === 1;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid variables with short names like $e. Configured minimum length is 3. Open
Open
$sumBase = array_reduce(str_split($vatNumber), function ($acc, $e) {- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}