DragonBe/vies

View on GitHub
src/Vies/Vies.php

Summary

Maintainability
B
7 hrs
Test Coverage

File Vies.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare (strict_types=1);

/**
Severity: Minor
Found in src/Vies/Vies.php - About 2 hrs to fix

    Method validateVat has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        public function validateVat(
            string $countryCode,
            string $vatNumber,
            string $requesterCountryCode = '',
            string $requesterVatNumber = '',
    Severity: Major
    Found in src/Vies/Vies.php - About 2 hrs to fix

      Vies has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Vies
      {
          const VIES_PROTO = 'https';
          const VIES_DOMAIN = 'ec.europa.eu';
          const VIES_PORT = 443;
      Severity: Minor
      Found in src/Vies/Vies.php - About 2 hrs to fix

        Method validateVat has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $countryCode,
                string $vatNumber,
                string $requesterCountryCode = '',
                string $requesterVatNumber = '',
                string $traderName = '',
        Severity: Major
        Found in src/Vies/Vies.php - About 1 hr to fix

          Function validateVat has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validateVat(
                  string $countryCode,
                  string $vatNumber,
                  string $requesterCountryCode = '',
                  string $requesterVatNumber = '',
          Severity: Minor
          Found in src/Vies/Vies.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method validateVat() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              public function validateVat(
                  string $countryCode,
                  string $vatNumber,
                  string $requesterCountryCode = '',
                  string $requesterVatNumber = '',
          Severity: Minor
          Found in src/Vies/Vies.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Missing class import via use statement (line '451', column '27').
          Open

                          throw new \InvalidArgumentException('The provided argument is not valid');
          Severity: Minor
          Found in src/Vies/Vies.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          The method validateCountryCode has a boolean flag argument $useExcludedCountries, which is a certain sign of a Single Responsibility Principle violation.
          Open

              private function validateCountryCode(string $countryCode, bool $useExcludedCountries = false): bool
          Severity: Minor
          Found in src/Vies/Vies.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          syntax error, unexpected ')'
          Open

                      ));
          Severity: Critical
          Found in src/Vies/Vies.php by phan

          There are no issues that match your filters.

          Category
          Status