Sign upLogin

Drakirus/Sudoku

View on GitHub
Star
class/suggest_class.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create_candidate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  private def create_candidate

    # les possibles valeurs sur les boxes
    @boxes = {}
    @rows = {}
Severity: Minor
Found in class/suggest_class.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for create_candidate is too high. [10/6]
Open

  private def create_candidate

    # les possibles valeurs sur les boxes
    @boxes = {}
    @rows = {}
Severity: Minor
Found in class/suggest_class.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method create_candidate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private def create_candidate

    # les possibles valeurs sur les boxes
    @boxes = {}
    @rows = {}
Severity: Minor
Found in class/suggest_class.rb - About 1 hr to fix

    Method hiddenSingle_on_container has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def hiddenSingle_on_container container, cont_possibles
    container.shuffle.each do |cont|

      # Récupération de la Cell qui a une unique possibilité
      uniq_candi = cont_possibles[cont[0]].sort.chunk{ |e| e }.map{ |_a, e| e.first if e.length == 1}.select{|e| e != nil}.first
    Severity: Minor
    Found in class/suggest_class.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hiddenSingle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def hiddenSingle
    bool = hiddenSingle_on_container @boxes, @possible_in_boxes
    bool = hiddenSingle_on_container @rows, @possible_in_rows unless bool
    bool = hiddenSingle_on_container @cols, @possible_in_cols unless bool
    @text_info << "Cette technique ne permet \npas actuellement de révéler de \nnouvelle case..." unless bool
    Severity: Minor
    Found in class/suggest_class.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method nakedSingle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def nakedSingle
    bool = nakedSingle_on_container @boxes
    bool = nakedSingle_on_container @rows unless bool
    bool = nakedSingle_on_container @cols unless bool
    @text_info << "Cette technique ne permet \npas actuellement de révéler de \nnouvelle case..." unless bool
    Severity: Minor
    Found in class/suggest_class.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status