Sign upLogin

Drakirus/Sudoku

View on GitHub
Star
vue/component_board.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initBoard has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initBoard(board)
    @board=board
    @board.snapshot unless @board.complete?

    # container of all CellComponent
Severity: Minor
Found in vue/component_board.rb - About 1 hr to fix

    Method initBoard has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def initBoard(board)
    @board=board
    @board.snapshot unless @board.complete?

    # container of all CellComponent
    Severity: Minor
    Found in vue/component_board.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method highlightCurrentNum has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def highlightCurrentNum(cellComp)
    @cellsView.each do |cell|
      if  !cellComp.cell.vide? and cellComp.cell.value == cell.cell.value
        if cell!=cellComp
          cell.change_style("color", GlobalOpts.getSelectColor)
    Severity: Minor
    Found in vue/component_board.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use sample instead of shuffle.first.
    Open

        @cellsView.shuffle.first.change_style("color", GlobalOpts.getBackgroundColor)
    Severity: Minor
    Found in vue/component_board.rb by rubocop

    This cop is used to identify usages of shuffle.first, shuffle.last and shuffle[] and change them to use sample instead.

    Example:

    # bad
[1, 2, 3].shuffle.first
[1, 2, 3].shuffle.first(2)
[1, 2, 3].shuffle.last
[1, 2, 3].shuffle[2]
[1, 2, 3].shuffle[0, 2]    # sample(2) will do the same
[1, 2, 3].shuffle[0..2]    # sample(3) will do the same
[1, 2, 3].shuffle(random: Random.new).first

# good
[1, 2, 3].shuffle
[1, 2, 3].sample
[1, 2, 3].sample(3)
[1, 2, 3].shuffle[1, 3]    # sample(3) might return a longer Array
[1, 2, 3].shuffle[1..3]    # sample(3) might return a longer Array
[1, 2, 3].shuffle[foo, bar]
[1, 2, 3].shuffle(random: Random.new)

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def highlightBox box_num
    return if not box_num
    @cellsView.each do |cell|
      if cell.cell.box == box_num
        cell.change_style("background", GlobalOpts.getSurligneColor)
    Severity: Minor
    Found in vue/component_board.rb and 1 other location - About 15 mins to fix
    vue/component_board.rb on lines 89..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def highlightNumber number
    return if not number
    @cellsView.each do |cell|
      if cell.cell.value == number
        cell.change_style("color", GlobalOpts.getSelectColor)
    Severity: Minor
    Found in vue/component_board.rb and 1 other location - About 15 mins to fix
    vue/component_board.rb on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status