Sign upLogin

DrawYourPath/DrawYourPath

View on GitHub
Star
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt

Summary

Maintainability
B
4 hrs
Test Coverage
A
96%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun loginWithEmailAndPassword(email: String, password: String) {
        Log.i("Login", "Trying to login with email.")
        auth.loginWithEmail(email, password) { user, error -> onLoginResult(user, error) }
    }
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 1 hr to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 194..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun registerWithEmailAndPassword(email: String, password: String) {
        Log.i("Login", "Trying to register with email.")
        auth.registerWithEmail(email, password) { user, error -> onRegistrationResult(user, error) }
    }
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 1 hr to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 189..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private fun onRegistrationResult(user: User?, error: Exception?) {
        when (error) {
            null -> {
                Log.i("Login", "Registered, redirecting to main activity.")
                openAccountRegistration()
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 164..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private fun onLoginResult(user: User?, error: Exception?) {
        when (error) {
            null -> {
                Log.i("Login", "Logged in, redirecting to main activity.")
                openMainMenu()
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 154..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun registerWithGoogle() {
        Log.i("Login", "Trying to register with Google.")
        auth.registerWithGoogle(this) { user, error -> onRegistrationResult(user, error) }
    }
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 184..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun loginWithGoogle() {
        Log.i("Login", "Trying to login with Google.")
        auth.loginWithGoogle(this) { user, error -> onLoginResult(user, error) }
    }
Severity: Minor
Found in app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/epfl/drawyourpath/login/LoginActivity.kt on lines 174..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status