Sign upLogin

Drosty/truegm

View on GitHub
Star
app/models/stat.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method defensive_points_allowed_points has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def defensive_points_allowed_points league
      return 0 if nfl_player.nil?
      return 0 unless nfl_player.position.upcase == "DEF"

      if self.points_allowed.to_i < 7
Severity: Minor
Found in app/models/stat.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return league.defensive_points_allowed_under_21_points
Severity: Major
Found in app/models/stat.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return league.defensive_points_allowed_under_35_points
Severity: Major
Found in app/models/stat.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return league.defensive_points_allowed_under_28_points
Severity: Major
Found in app/models/stat.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status