Sign upLogin

Drosty/truegm

View on GitHub
Star
app/services/spotrac/spotrac_service.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method process_spotrac_salary_data has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def self.process_spotrac_salary_data
      NflPlayer.find_each do |player|
        next if player.full_name == "Kevin Norwood"
        next if player.full_name == "Rueben Randle"
        next if player.full_name == "Chris Givens"
Severity: Minor
Found in app/services/spotrac/spotrac_service.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_spotrac_player_data has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def self.process_spotrac_player_data
      NflTeam.all.each do |nfl_team|
        puts "processing: " + nfl_team.full_name + " " + nfl_team.spotrac_url

        nfl_page = Nokogiri::HTML(open(nfl_team.spotrac_url))
Severity: Minor
Found in app/services/spotrac/spotrac_service.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status