Sign upLogin

Drosty/truegm

View on GitHub
Star

Showing 27 of 27 total issues

Avoid too many return statements within this method.
Open

        return league.defensive_points_allowed_under_28_points
Severity: Major
Found in app/models/stat.rb - About 30 mins to fix

Method sortable_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def sortable_link(column, title = nil)
    title ||= column.titleize
    css_class = column == sort_column ? "current #{sort_direction}" : nil
    direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
    link_to title, params.merge(:sort => column, :direction => direction, :page => nil), {:class => css_class}
Severity: Minor
Found in app/helpers/nfl_players_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method stat_catagories_headers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def stat_catagories_headers
    if @player.position == Position::QUARTERBACK
      ["Passing", "Rushing"]

    elsif @player.position == Position::RUNNINGBACK
Severity: Minor
Found in app/models/nfl_player_view_model.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_receiving_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = ReceivingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_rushing_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = RushingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 71..77
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_passing_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = PassingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 71..77
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_kicking_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = KickingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 71..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language