Dulce-Work-Schedule/2018.1-Dulce_Login

View on GitHub

Showing 4 of 7 total issues

Function api has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function api(options) {
  this.add('role:api, path:create', function (msg, respond) {
    var firstName = {
      verbose: 'Primeiro Nome',
      field_name: 'firstName'
Severity: Major
Found in Client/api.js - About 6 hrs to fix

    Function exports has 103 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(options){
      this.add('role:user, cmd:create', async function create( msg, respond) {
        var user = this.make('users')
        user.firstName = msg.firstName
        user.lastName = msg.lastName
    Severity: Major
    Found in Server/_user.js - About 4 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      require('seneca')()
      .use("entity")
      .use('mongo-store',{
        name: process.env.MONGO_DATABASE,
        host: process.env.MONGO_HOST,
      Severity: Major
      Found in Server/user.js and 1 other location - About 1 hr to fix
      Client/client_user.js on lines 45..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      var seneca = require('seneca')()
          .use(SenecaWeb, senecaWebConfig)
          .use('seneca-amqp-transport')
          .use("entity")
          .use('api')
      Severity: Major
      Found in Client/client_user.js and 1 other location - About 1 hr to fix
      Server/user.js on lines 1..17

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language