Sign upLogin

DzmitrySha/python-project-lvl2

View on GitHub
Star
gendiff/formatters/stylish.py

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Function iter_ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def iter_(node: dict, depth=0) -> str:
    children = node.get('children')
    indent = get_indent(depth)
    formatted_value = to_string(node.get('value'), depth)
    formatted_value1 = to_string(node.get('old_value'), depth)
Severity: Minor
Found in gendiff/formatters/stylish.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function to_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def to_string(value, depth: int) -> str:
    if isinstance(value, bool):
        return 'true' if value else 'false'

    if value is None:
Severity: Minor
Found in gendiff/formatters/stylish.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return f"{indent}- {node['key']}: {formatted_value}"
Severity: Major
Found in gendiff/formatters/stylish.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return f"{indent}+ {node['key']}: {formatted_value}"
    Severity: Major
    Found in gendiff/formatters/stylish.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status