Sign upLogin

EGI-FCTF/oneacct_export

View on GitHub
Star
lib/data_validators/data_validator_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method default has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def default(value, condition_method, default_value)
      return string?(value) ? value : default_value if condition_method == :string
      return number?(value) ? value : default_value if condition_method == :number
      return decimal?(value) ? value : default_value if condition_method == :decimal
      return non_zero_number?(value) ? value : default_value if condition_method == :nzn
Severity: Minor
Found in lib/data_validators/data_validator_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status